====================================================== WARNING: possible circular locking dependency detected 5.15.180-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.554/6863 is trying to acquire lock: ffff888060ee6628 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x332/0x1c60 fs/ext4/inode.c:597 but task is already holding lock: ffff888057b0c208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x12b/0x190 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 v2_read_dquot+0x4a/0x110 fs/quota/quota_v2.c:332 dquot_acquire+0x152/0x520 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2d9/0x4a0 fs/ext4/super.c:6200 dqget+0x778/0xeb0 fs/quota/dquot.c:988 __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517 ext4_mkdir+0x16c/0xc50 fs/ext4/namei.c:3059 vfs_mkdir+0x387/0x570 fs/namei.c:4065 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x5a/0x410 fs/quota/dquot.c:507 ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6180 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0x5d0/0xe20 fs/quota/dquot.c:1752 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xf68/0x4940 fs/ext4/mballoc.c:5739 ext4_ext_map_blocks+0x146c/0x64e0 fs/ext4/extents.c:4339 ext4_map_blocks+0x9cd/0x1c60 fs/ext4/inode.c:672 _ext4_get_block+0x1d7/0x4e0 fs/ext4/inode.c:815 ext4_block_write_begin+0x60f/0x1210 fs/ext4/inode.c:1100 ext4_write_begin+0x6c2/0x15c0 fs/ext4/ext4_jbd2.h:-1 ext4_da_write_begin+0x435/0xb30 fs/ext4/inode.c:2974 generic_perform_write+0x2aa/0x530 mm/filemap.c:3785 ext4_buffered_write_iter+0x25f/0x3b0 fs/ext4/file.c:268 ext4_file_write_iter+0x773/0x17b0 fs/ext4/file.c:-1 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x712/0xd00 fs/read_write.c:594 ksys_write+0x14d/0x250 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x332/0x1c60 fs/ext4/inode.c:597 ext4_getblk+0x16d/0x630 fs/ext4/inode.c:869 ext4_bread+0x26/0x180 fs/ext4/inode.c:922 ext4_quota_write+0x230/0x570 fs/ext4/super.c:6574 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x387/0x7d0 fs/quota/quota_tree.c:125 do_insert_tree+0x214/0x1970 fs/quota/quota_tree.c:335 do_insert_tree+0x5b1/0x1970 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x361/0x4b0 fs/quota/quota_tree.c:411 v2_write_dquot+0x108/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x2d5/0x520 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2d9/0x4a0 fs/ext4/super.c:6200 dqget+0x778/0xeb0 fs/quota/dquot.c:988 __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517 ext4_rename fs/ext4/namei.c:3895 [inline] ext4_rename2+0x96a/0x3000 fs/ext4/namei.c:4272 vfs_rename+0xbbf/0x10d0 fs/namei.c:4832 do_renameat2+0xa83/0xf70 fs/namei.c:4985 __do_sys_rename fs/namei.c:5031 [inline] __se_sys_rename fs/namei.c:5029 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5029 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 5 locks held by syz.2.554/6863: #0: ffff888057b0c460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:377 #1: ffff888060ee03f0 (&type->i_mutex_dir_key#4/1){+.+.}-{3:3}, at: lock_rename include/linux/fs.h:-1 [inline] #1: ffff888060ee03f0 (&type->i_mutex_dir_key#4/1){+.+.}-{3:3}, at: do_renameat2+0x42a/0xf70 fs/namei.c:4924 #2: ffff8880729649b8 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #2: ffff8880729649b8 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: vfs_rename+0x81f/0x10d0 fs/namei.c:4797 #3: ffff88807291a7a8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x63/0x520 fs/quota/dquot.c:460 #4: ffff888057b0c208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x12b/0x190 fs/quota/quota_v2.c:354 stack backtrace: CPU: 1 PID: 6863 Comm: syz.2.554 Not tainted 5.15.180-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call Trace: dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x332/0x1c60 fs/ext4/inode.c:597 ext4_getblk+0x16d/0x630 fs/ext4/inode.c:869 ext4_bread+0x26/0x180 fs/ext4/inode.c:922 ext4_quota_write+0x230/0x570 fs/ext4/super.c:6574 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x387/0x7d0 fs/quota/quota_tree.c:125 do_insert_tree+0x214/0x1970 fs/quota/quota_tree.c:335 do_insert_tree+0x5b1/0x1970 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x361/0x4b0 fs/quota/quota_tree.c:411 v2_write_dquot+0x108/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x2d5/0x520 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2d9/0x4a0 fs/ext4/super.c:6200 dqget+0x778/0xeb0 fs/quota/dquot.c:988 __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517 ext4_rename fs/ext4/namei.c:3895 [inline] ext4_rename2+0x96a/0x3000 fs/ext4/namei.c:4272 vfs_rename+0xbbf/0x10d0 fs/namei.c:4832 do_renameat2+0xa83/0xf70 fs/namei.c:4985 __do_sys_rename fs/namei.c:5031 [inline] __se_sys_rename fs/namei.c:5029 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5029 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f4f29b76969 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f4f279de038 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f4f29d9dfa0 RCX: 00007f4f29b76969 RDX: 0000000000000000 RSI: 0000200000000200 RDI: 0000200000000580 RBP: 00007f4f29bf8ab1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f4f29d9dfa0 R15: 00007ffce019f628 Quota error (device loop2): do_check_range: Getting dqdh_next_free 4294967294 out of range 0-8 Quota error (device loop2): qtree_write_dquot: Error -117 occurred while creating quota EXT4-fs error (device loop2): ext4_acquire_dquot:6204: comm syz.2.554: Failed to acquire dquot type 0